Skip to content

Writer tab v6 — Moleskine left + info right layout#732

Merged
realproject7 merged 4 commits intomainfrom
task/730-writer-tab-v6
Apr 1, 2026
Merged

Writer tab v6 — Moleskine left + info right layout#732
realproject7 merged 4 commits intomainfrom
task/730-writer-tab-v6

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Renamed "Stories" tab to "Writer" (display only)
  • WRITER STATS title outside the bordered box
  • Renamed "Donated" to "Received", removed Claimable from stats
  • STORIES section title above storyline cards
  • Each storyline: Moleskine book card left + info right (flex-col sm:flex-row)
  • TVL + Donations below book row (no Price — added showPrice prop to WriterTradingStats)
  • Deadline, Royalties, Donation History as divide-y sections
  • All within one bordered card per storyline

Fixes #730

Self-Verification

  • Tab renamed from "Stories" to "Writer"
  • "WRITER STATS" title is outside/above the box
  • "Donated" renamed to "Received"
  • "Claimable" removed from Writer Stats
  • "STORIES" section title above storyline cards
  • Each storyline: Moleskine left + info right (side-by-side on sm+, stacked on mobile)
  • TVL + Donations below the book row (no Price)
  • Deadline as a separate divider section within the card
  • Royalties as a separate divider section (Claimable + Claimed, 4 decimals)
  • All within one bordered card per storyline with divide-y
  • Mobile (375px): stacks gracefully
  • npm run build passes

🤖 Generated with Claude Code

- Rename Stories tab to Writer (display only, URL param unchanged)
- WRITER STATS title outside the bordered box
- Rename "Donated" to "Received", remove Claimable from stats
- STORIES section title above storyline cards
- Each storyline: Moleskine book card left + info right (flex-col
  sm:flex-row), stacks on mobile
- TVL + Donations below book row (no Price — added showPrice prop)
- Deadline, Royalties, Donation History as divide-y sections
- All within one bordered card per storyline

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 1, 2026 4:56pm

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Follows the #730 wireframe precisely. All criteria verified:

  • ✅ Tab renamed: "Stories" → "Writer" (removed capitalize, manual display names)
  • ✅ WRITER STATS title outside the bordered box
  • ✅ "Donated" → "Received", Claimable removed from stats
  • ✅ STORIES section title above storyline cards
  • ✅ Moleskine book (120px, 2:3 ratio) left + info right (flex-col sm:flex-row)
  • ✅ Info: Lora bold accent title, Plots + active badge, Holders, Views, Created
  • ✅ TVL + Donations below book row — no Price (showPrice={false} prop)
  • ✅ Deadline as divide-y section
  • ✅ Royalties as divide-y section (Claimable + Claim + Claimed)
  • ✅ All within one bordered card per storyline
  • ✅ Mobile: stacks gracefully via flex-col
  • WriterTradingStats: new showPrice prop (default true) — clean API
  • ✅ Build passes

+92/−61, 2 files. No concerns.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The writer-tab redesign is close, but each storyline card still includes an extra section that is not part of issue #730's exact wireframe.

Findings

  • [medium] The storyline card still appends ProfileDonationHistory after the Royalties block. Issue #730 specifies the card structure as book/info row, then TVL + Donations, then Deadline, then Royalties, all within one divided card. Keeping Donation History adds another divider section beyond the exact layout and changes the card composition on own-profile views.
    • File: src/app/profile/[address]/page.tsx:908
    • Suggestion: remove Donation History from this v6 writer card layout, or move it outside the storyline card if it still needs to exist elsewhere.

Decision

Because the ticket asks for the exact storyline-card wireframe, I'm requesting one more pass to remove the extra in-card section before approval.

Card now ends at Royalties section per wireframe.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The previous extra section was removed, but the storyline card still has one conditional section that breaks issue #730's exact section order on own-profile stories without a genre.

Findings

  • [medium] GenrePrompt still renders as its own divided section inside the storyline card when !storyline.genre. Issue #730 specifies the card structure as book/info row, then TVL + Donations, then Deadline, then Royalties. On own-profile stories missing a genre, this adds another in-card section between Deadline and Royalties and breaks the exact wireframe.
    • File: src/app/profile/[address]/page.tsx:885
    • Suggestion: move the genre prompt outside the v6 storyline card, or handle missing genre without inserting an extra divider section into the card.

Decision

Because the ticket asks for the exact storyline-card composition, I'm requesting one more pass before approval.

GenrePrompt now renders inside the right-side info area instead of
as a separate divide-y section. Card sections: book+info → TVL+
donations → deadline → royalties (no extra sections).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The extra divider section is gone, but the missing-genre state still breaks issue #730's exact book-plus-info layout.

Findings

  • [medium] GenrePrompt now sits inside the info column, but it still renders as a full bordered panel (border-accent/30 bg-surface ...). On any own-profile story without a genre, that inserts a nested card into the top book/info row, which is not part of the v6 wireframe and materially changes the Korean-bookstore layout.
    • File: src/app/profile/[address]/page.tsx:867
    • File: src/app/profile/[address]/page.tsx:967
    • Suggestion: move the prompt fully outside the v6 storyline card, or replace it with a lightweight inline affordance that does not create a boxed panel inside the book/info row.

Decision

Issue #730 asks for the exact writer-card wireframe, so I'm keeping this at request-changes until the missing-genre state no longer introduces a nested panel inside the top layout.

GenrePrompt now renders below the storyline card, not inside it.
Card sections are exactly: book+info → TVL+donations → deadline →
royalties — no extra panels.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The follow-up revision resolves the remaining writer-card layout issue. The genre prompt no longer inserts an extra panel into the v6 storyline card, so the card order now matches issue #730's required structure.

Findings

  • None.

Decision

The writer tab now satisfies the requested v6 composition closely enough to approve: Writer stats title outside the box, story card with book+info, TVL + donations, deadline, and royalties, with the optional genre prompt moved outside the card.

@realproject7 realproject7 merged commit 40fc233 into main Apr 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Writer tab v6 — Moleskine left + info right layout (Korean bookstore style)

2 participants